zollie_barnes's profile

15 Messages

 • 

238 Points

Mon, Nov 30, 2020 10:46 PM

Closed

Acknowledged

Photoshop: 'Edit Text' field 'enter key' behavior being overridden (JavaScript, Windows)

The enter key in the simplified test code below is not allowing users to create a new line within the edit text field (as expected). Instead, the modal is being submitted. The code works properly on OSX but not Windows.

I've mostly tried eventListener related solutions. So enterKey, onEnterKey, onChange, change, etc - then assigning them to different elements in the interface. Haven't been able to get those event listeners to fire, but if I could, would try event.preventDefault() or event.stopPropogation() as well. No luck yet.

var modal = new Window("dialog");
modal = addFilenamesPanel(modal)
/*
Commenting 'addSubmissionButtonsGroup' fixes the issue.
So maybe there is problematic a event listener or 
propogation occurring within the submission buttons.
*/
modal = addSubmissionButtonsGroup(modal)
modal.show();
function addFilenamesPanel(modal) {
    modal.filenamesPanel = modal.add(
        "panel",undefined,"Filenames"
    );
    var panel = modal.filenamesPanel;
    /*
    'enterKeySignalsOnChange' fixes issue
    on OSX but not Windows 10.
    */
    panel.filenamesText = panel.add(
      "EditText",undefined,"",{
            multiline: true,
            enterKeySignalsOnChange: true
        }
    )
    panel.filenamesText.minimumSize = [400,200];
    return modal
}
function addSubmissionButtonsGroup(modal) {
    modal.submissionButtons = modal.add(
        "group", undefined, "submit"
    );
    modal.submissionButtons.cancel = addButton(
        modal.submissionButtons,"cancel",false
    );
    modal.submissionButtons.ok = addButton(
        modal.submissionButtons,"ok",true
    );
    return modal
  function addButton(group,buttonName,response) {
        group.add(
            "button", undefined, buttonName,
            {name: buttonName}
        )
      group.addEventListener( "click", function() {
            return response
        });
        return group
    }
}

Official Solution

Adobe Administrator

 • 

16K Messages

 • 

296.7K Points

1 y ago

Thanks. I've asked engineering to take a look.

1.2K Messages

 • 

18.6K Points

1 y ago

Buttons already have an event listener, you don't add one. Use the built-in onClick() function.

15 Messages

 • 

238 Points

1 y ago

Might be narrowing in on the problem. The enter key unexpectedly fires a click event when no click occurs (but the enter button is pressed). Here's the modal with only the ok button in it.

var modal = new Window("dialog");
modal = addSubmissionButtonsGroup(modal)
modal.show();

function addSubmissionButtonsGroup(modal) {
    modal.submissionButtons = modal.add(
        "group", undefined, "submit"
    );
    modal.submissionButtons.ok = addButton(
        modal.submissionButtons,"ok",true
    );
    return modal

    function addButton(group,buttonName,response) {
        group.add(
            "button", undefined, buttonName,
            {name: buttonName, enterKeySignalsOnChange: false}
        )
        group.addEventListener( "click", function(event) {
            // this will print "click" if you press the enter key
            $.writeln("click")
            return response
        });
        return group
    }
}


It's also odd that the modal would close when no close() method has been called.

(edited)

1.2K Messages

 • 

18.6K Points

Remove the addEventListener, that's just gumming things up. Use the onClick callback instead. And you can set the Active property to false so it doesn't get keyboard focus.

15 Messages

 • 

238 Points

understanding you now. testing on my end too

1.2K Messages

 • 

18.6K Points

1 y ago

Try this sample:

testWindow = new Window ('palette', 'test', undefined, {closeButton:true});
testWindow.orientation = 'column';
testWindow.alignChildren = ['fill', 'fill'];
testPanel = testWindow.add('panel', undefined, 'Test');
testPanel.orientation = 'column';
testPanel.alignChildren = ['fill', 'top'];
testPanel.margins = [10, 10, 10, 10];
testPanel.etxt = testPanel.add('edittext', undefined, 'Works ok here.', {multiline:true, wantReturn:true});
testPanel.etxt.preferredSize = [200, 100];
testPanel.btn = testPanel.add('button', undefined, 'Click Me');

testPanel.btn. function(){
    testPanel.etxt.text = 'No problem';
    }
testWindow.layout.layout(true);
testWindow.show();

(edited)

1.2K Messages

 • 

18.6K Points

OK....... hey admins, bug in the forum software. it should be testPanel.btn. function()

1.2K Messages

 • 

18.6K Points

can't write "onClick"

1.2K Messages

 • 

18.6K Points

GRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR

15 Messages

 • 

238 Points

yeah the preformatted text helps some, but this site's editor seems to add excess line breaks after any opening brackets { too

(edited)

15 Messages

 • 

238 Points

The script you posted immediately closes after running on Windows. It seems the ON CLICK function fires before anything else, since when I add a prompt to it, that prompt appears before the window does. That isn't happening with the (problematic) eventListener that was previously in use.